Fix behaviour when config loading fails #30
Merged
+1
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When loading a config and result is falsy, set empty config for result.
fixes #26
Types of changes
What types of changes does your code introduce
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is a reminder of what we are going to look for before merging your code.Further comments
Do you have any suggestions on how to add a test for this?
cosmiconfig
searches the file tree, and there is a config in the file tree, so, I wasn't sure the best approach to write a test that does not have a config? I will think a little longer on it, but wanted to get the PR open and see if anyone had suggestions.I did not see a CONTRIBUTING.md file or contributing guidelines in this repo, so I did the best I could to follow what I believe would be expected. Let me know if I missed anything.
Reviewers: @michael-ciniawsky, @ertrzyiks